Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dark mode in contributors page #1212

Closed
wants to merge 1 commit into from
Closed

feat: add dark mode in contributors page #1212

wants to merge 1 commit into from

Conversation

ANKeshri
Copy link
Contributor

@ANKeshri ANKeshri commented Jul 24, 2024 •
edited
Loading

Title and Issue number

Title : add dark mode in contributors page

Issue No. : #1210

Code Stack : html css and js

Close #1210

Description

dark mode feature in contributors page

Video/Screenshots (mandatory)

before :

Screenshot 2024-07-24 231352

after :

Recording.2024-07-25.010412.mp4

Type of PR

  • Feature enhancement

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

@netlify Netlify
Copy link

netlify bot commented Jul 24, 2024 •
edited
Loading

✅ Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 6aa13b7
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66a15846d2b7d000081063c2
😎 Deploy Preview https://deploy-preview-1212--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ANKeshri
Copy link
Contributor Author

@apu52 please review once and merge my pr

apu52
apu52 requested changes Jul 25, 2024
View reviewed changes
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ANKeshri the color scheme of the dark mode of the booking page u have added is not matching with the other parts of the website & also it's not catchy for the users also , please try to improve it with better UI

@apu52 apu52 added the help wanted Extra attention is needed label Jul 25, 2024
@ANKeshri ANKeshri closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apu52 apu52 apu52 requested changes

Assignees

@ANKeshri ANKeshri

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Dark mode for contributors page
2 participants
@ANKeshri @apu52